update EnvironmentCredential and azure.core.util.Configuration #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxznmhdcxz
requested review from
alzimmermsft,
g2vinay,
hemanttanwar,
jianghaolu and
srnagar
as code owners
jongio
requested changes
Jan 16, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/EnvironmentCredential.java
Outdated
Show resolved
Hide resolved
…vironmentCredential
jianghaolu
approved these changes
Jan 17, 2020
|
Adding @alzimmermsft to review the azure-core change. |
sdk/core/azure-core/src/main/java/com/azure/core/util/Configuration.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/EnvironmentCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/EnvironmentCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/EnvironmentCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/test/java/com/azure/identity/EnvironmentCredentialTests.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/test/java/com/azure/identity/EnvironmentCredentialTests.java
Outdated
Show resolved
Hide resolved
ellismg
reviewed
Jan 18, 2020
sdk/identity/azure-identity/src/test/java/com/azure/identity/EnvironmentCredentialTests.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/test/java/com/azure/identity/EnvironmentCredentialTests.java
Outdated
Show resolved
Hide resolved
alzimmermsft
approved these changes
Jan 21, 2020
ellismg
requested changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated EnvironmentCredential to support env vars for UsernamePasswordCredential and ClientCertificateCredential. Added PROPERTY_AZURE_CLIENT_CERTIFICATE_PATH to azure.core.util.Configuration.
#5967